Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

Le 21/03/2021 à 12:07, er(at)xs4all(dot)nl a écrit :
>> On 2021.03.20. 19:48 Gilles Darold <gilles(at)darold(dot)net> wrote:
>>
>> This is a new version of the patch that now implements all the XQUERY
>> regexp functions as described in the standard, minus the differences of
>> PostgerSQL regular expression explain in [1].
>>
>> The standard SQL describe functions like_regex(), occurrences_regex(),
>> position_regex(), substring_regex() and translate_regex() which
>> correspond to the commonly named functions regexp_like(),
>> regexp_count(), regexp_instr(), regexp_substr() and regexp_replace() as
>> reported by Chapman Flack in [2]. All these function are implemented in
>> [v2-0001-xquery-regexp-functions.patch]
> Hi,
>
> Apply, compile and (world)check are fine. I haven't found errors in functionality.
>
> I went through the docs, and came up with these changes in func.sgml, and pg_proc.dat.
>
> Useful functions - thanks!
>
> Erik Rijkers

Thanks a lot Erik, here is a version of the patch with your corrections.

--
Gilles Darold
LzLabs GmbH
http://www.lzlabs.com/