| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Edmund Horner <ejrh00(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench doc typos |
| Date: | 2018-04-11 12:40:45 |
| Message-ID: | 9da71e57-e931-ccfd-0825-466fe9d60cbb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/30/18 03:30, Edmund Horner wrote:
> On 30 March 2018 at 19:26, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>> Thanks for the check. You might consider turning the patch as ready in the
>> cf app.
>
> Ok, I have done so, since the patch is small and simple.
>
>>> Fixing the abs/hash bracketing seems clear. The wasn't sure about
>>> rewriting "mod(i, bj)" as "mod(i, j)", because there could be some
>>> convention about parameter names, but I can't think of anything the "b"
>>> could be in the case of mod.
>>
>>
>> Might be a left-over a previous version which might have used MOD(a, b), but
>> a/b are rather used for fp numbers and i/j for integers.
>
> Ah that seems possible.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-04-11 13:13:56 | Re: [WIP] Document update for Logical Replication security |
| Previous Message | Alvaro Herrera | 2018-04-11 12:35:54 | Re: [HACKERS] path toward faster partition pruning |