| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: display hot standby state in psql prompt |
| Date: | 2025-07-23 08:03:54 |
| Message-ID: | 9d45ca06-cd8b-44bc-9647-c7dd5f4595cd@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Srinath
On 23.07.25 09:03, Srinath Reddy Sadipiralla wrote:
> +1 for the patch,i have reviewed and tested this patch, except these
> below cosmetic changes it LGTM.
>
> cosmetic changes:
> 1) add comment about %i in get_prompt api.
Done.
> 2) maybe we can use read-write instead of read/write to be consistent
> with the
> naming such as options of target_session_attrs uses read-write.
I believe that 'read/write' is more idiomatic than 'read-write' in this
context. 'Read-only' works as a hyphenated adjective, and 'read/write'
is typically treated as a paired label that indicates two distinct
capabilities --- read and write. What do you think?
v3 attached.
Thanks for the thorough testing and review!
Best, Jim
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-i-prompt-escape-to-indicate-server-read-only-.patch | text/x-patch | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-07-23 08:09:54 | Re: Custom pgstat support performance regression for simple queries |
| Previous Message | Joel Jacobson | 2025-07-23 07:42:33 | Re: Interrupts vs signals |