Re: Log a sample of transactions

From: Adrien NAYRAT <adrien(dot)nayrat(at)anayrat(dot)info>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "PostgreSQL mailing lists" <pgsql-hackers(at)postgresql(dot)org>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>
Subject: Re: Log a sample of transactions
Date: 2019-01-17 10:30:01
Message-ID: 9ca67528-1685-f74c-3f48-5840dc7755f2@anayrat.info
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 1/16/19 10:09 AM, Masahiko Sawada wrote:
> Since we set xact_is_sampled only when transaction starts and see it
> during transaction we cannot disable logging during transaction and
> vice versa. I can imagine the use case where user wants to disable
> logging during transaction. So it might be better to also check if
> log_xact_sample_rate > 0 in check_log_duration().

I Agree, here is third patch.

Thanks!

Attachment Content-Type Size
log_xact-3.patch text/x-patch 6.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2019-01-17 10:59:18 Re: Libpq support to connect to standby server as priority
Previous Message Amit Langote 2019-01-17 10:24:47 Re: speeding up planning with partitions