From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Suggested fix for \p and \r in psql |
Date: | 2017-04-02 13:22:04 |
Message-ID: | 9b4ea968-753f-4b5f-b46c-d7d3bf7c8f90@manitou-mail.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I've noticed two issues with the query buffer post-commit e984ef5
(Support \if ... \elif ... \else ... \endif in psql scripting):
1. \p ignores the "previous buffer". Example:
postgres=# select 1;
?column?
----------
1
(1 row)
postgres=# \p
Query buffer is empty.
That doesn't match the pre-commit behavior, and is not
consistent with \e or \w
2. \r keeps the "previous buffer". I think it should clear it. Example:
postgres=# select 1;
?column?
----------
1
(1 row)
postgres=# select 2 \r
Query buffer reset (cleared).
postgres=# \w /tmp/buffer
postgres=# \! cat /tmp/buffer
select 1;
I suggest the attached fix, with a few new regression tests.
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
Attachment | Content-Type | Size |
---|---|---|
psql-query-buffer.diff | text/x-patch | 5.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Konstantin Knizhnik | 2017-04-02 13:30:24 | FDW and parallel execution |
Previous Message | Fabien COELHO | 2017-04-02 13:14:46 | Re: Variable substitution in psql backtick expansion |