| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow an alias to be attached directly to a JOIN ... USING |
| Date: | 2019-12-30 21:25:30 |
| Message-ID: | 9a5c9ed2-1dd7-8c2a-6b90-0de54f4c13a1@2ndquadrant.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-12-24 19:13, Fabien COELHO wrote:
>>> Indeed, that seems like a problem, and it's a good question. You can
>>> see this on unpatched master with SELECT x.filler FROM
>>> (pgbench_tellers AS t JOIN b USING (bid)) AS x.
>>
>> I'm not sure I understand why that problem is a blocker for this patch.
>
> As discussed on another thread,
>
> https://www.postgresql.org/message-id/flat/2aa57950-b1d7-e9b6-0770-fa592d565dda(at)2ndquadrant(dot)com
>
> the patch does not conform to spec
>
> SQL:2016 Part 2 Foundation Section 7.10 <joined table>
>
> Basically "x" is expected to include *ONLY* joined attributes with USING,
> i.e. above only x.bid should exists, and per-table aliases are expected to
> still work for other attributes.
I took another crack at this. Attached is a new patch that addresses
the semantic comments from this and the other thread. It's all a bit
tricky, comments welcome.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Allow-an-alias-to-be-attached-to-a-JOIN-.-USING.patch | text/plain | 26.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-12-30 21:33:42 | Re: [PATCH] Increase the maximum value track_activity_query_size |
| Previous Message | Robert Treat | 2019-12-30 20:46:40 | Re: [PATCH] Increase the maximum value track_activity_query_size |