Re: Speed up clean meson builds by ~25%

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speed up clean meson builds by ~25%
Date: 2024-05-17 22:35:08
Message-ID: 9a3271ba-7896-46fe-9ae7-711b5565fbd9@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17.05.24 23:01, Robert Haas wrote:
> On Fri, May 17, 2024 at 4:59 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> As I mentioned upthread, I'm more worried about confusing error
>> reports than the machine time.
>
> Well, Jelte fixed that.
>
>> I grant that there are people who are more affected, but still, I'd
>> just as soon not contort the build rules for a temporary problem.
>
> Arguably by doing this, but I don't think it's enough of a contortion
> to get excited about.
>
> Anyone else want to vote?

I retested the patch from 2024-04-07 (I think that's the one that "fixed
that"? There are multiple "v1" patches in this thread.) using gcc-14
and clang-18, with ccache disabled of course. The measured effects of
the patch are:

gcc-14: 1% slower
clang-18: 3% faster

So with that, it doesn't seem very interesting.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-05-17 22:54:03 Re: libpq compression (part 3)
Previous Message David Steele 2024-05-17 22:14:27 Re: pg_combinebackup does not detect missing files