Re: make MaxBackends available in _PG_init

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: make MaxBackends available in _PG_init
Date: 2021-08-07 18:01:41
Message-ID: 9B2E85FE-14BC-407A-93B7-4EE2F84BEF05@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/3/21, 4:14 PM, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote:
> On 8/2/21, 4:02 PM, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote:
>> On 8/2/21, 3:42 PM, "Andres Freund" <andres(at)anarazel(dot)de> wrote:
>>> I've wondered, independent of this thread, about not making MaxBackends
>>> externally visible, and requiring a function call to access it. It should be
>>> easier to find cases of misuse if we errored out when accessed at the wrong
>>> time. And we could use that opportunity to add flags that determine which
>>> types of backends are included (e.g. not including autovac, or additionally
>>> including aux workers or prepared xacts).
>>
>> I'm not opposed to this. I can work on putting a patch together if no
>> opposition materializes.
>
> Here is a first attempt.

Here is a rebased version of the patch.

Nathan

Attachment Content-Type Size
v2-0001-Disallow-external-access-to-MaxBackends.patch application/octet-stream 30.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-08-07 18:51:41 Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Previous Message Peter Geoghegan 2021-08-07 18:00:24 Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE