| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Beena Emerson <memissemerson(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Memory unit GUC range checks |
| Date: | 2018-05-16 12:49:29 |
| Message-ID: | 9976fdbf-921d-3abb-4ed0-7251f34373d2@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16/05/18 15:19, Heikki Linnakangas wrote:
> $ postmaster -c track_activity_query_size=1024TB
> FATAL: invalid value for parameter "track_activity_query_size": "1024TB"
> HINT: Valid units for this parameter are "kB", "MB", "GB", and "TB".
>
> ...
>
> The HINT in the last message seems wrong: the hint claims that "TB" is
> accepted, yet "1024 TB" was not accepted. And shouldn't the hint also
> mention "B", since we accept that now?
>
>
> Testing a setting with GUC_UNIT_KB:
>
> $ postmaster -c work_mem=102400B
> FATAL: invalid value for parameter "work_mem": "100000B"
> HINT: Valid units for this parameter are "kB", "MB", "GB", and "TB".
>
> This time the hint is accurate, but why is "B" not accepted here? Seems
> inconsistent.
Here's a pretty straightforward fix for these two issues. Any objections
or better ideas?
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| byte-unit-fixes-1.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-05-16 13:11:31 | Re: Flexible permissions for REFRESH MATERIALIZED VIEW |
| Previous Message | Heikki Linnakangas | 2018-05-16 12:19:45 | Memory unit GUC range checks |