Re: BUG #19457: RE: pgp_sym_encrypt silently accepts non-FIPS ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, ansh01072001(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19457: RE: pgp_sym_encrypt silently accepts non-FIPS ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod
Date: 2026-04-24 15:27:27
Message-ID: 98BDEEAC-A401-41D8-B9C0-A1EBEBF2E08E@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 24 Apr 2026, at 17:18, Joe Conway <mail(at)joeconway(dot)com> wrote:
>
> On 4/24/26 10:38, Tom Lane wrote:
>> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>>> On 24 Apr 2026, at 06:20, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>>> I am interesting in getting that fixed for the next point release, so
>>>> I have given it a try, finishing with the attached. This would cause
>>>> pgp_sym_encrypt() and pgp_sym_decrypt() to complain when the builtin
>>>> mode is disabled, making things more consistent with the surroundings.
>>> I'm not convinced this is material for a minor release, the feature works as
>>> documented and it was never documented to cover PGP. Re-reading the thread PGP
>>> was never discussed, and while that admittedly seem like an oversight doing
>>> this in a minor release will alter documented behaviour which is generally not
>>> what we want to do.
>> I sympathize with that argument, but ... people who are running in
>> FIPS mode are probably doing so because they have contractual or legal
>> obligations to meet that standard. A person who could be in hot water
>> if they are accidentally running disallowed crypto would see this as a
>> dangerous bug. A person who does not care should not be using FIPS
>> mode.
>
> +1 I think we should consider this as a backpatchable bug.

Sounds good, I'll have a look at the two proposed patches.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2026-04-24 15:41:50 Re: to_date()/to_timestamp() silently accept month=0 and day=0
Previous Message Joe Conway 2026-04-24 15:18:28 Re: BUG #19457: RE: pgp_sym_encrypt silently accepts non-FIPS ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod