Re: Fixing backslash dot for COPY FROM...CSV

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: "vignesh C" <vignesh21(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fixing backslash dot for COPY FROM...CSV
Date: 2023-12-19 11:27:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

vignesh C wrote:

> I noticed that these tests are passing without applying patch too:

> +insert into copytest2(test) values('line1'), ('\.'), ('line2');
> +copy (select test from copytest2 order by test collate "C") to :'filename'
> csv;
> +-- get the data back in with copy
> +truncate copytest2;
> +copy copytest2(test) from :'filename' csv;
> +select test from copytest2 order by test collate "C";
> I was not sure if this was intentional. Can we add a test which fails
> in HEAD and passes with the patch applied.

Thanks for checking this out.
Indeed, that was not intentional. I've been using static files
in my tests and forgot that if the data was produced with
COPY OUT, it would quote backslash-dot so that COPY IN could
reload it without problem.

PFA an updated version that uses \qecho to produce the
data instead of COPY OUT. This test on unpatched HEAD
shows that copytest2 is missing 2 rows after COPY IN.

Best regards,
Daniel Vérité
Twitter: @DanielVerite

Attachment Content-Type Size
v2-0001-Support-backslash-dot-on-a-line-by-itself-as-vali.patch text/plain 5.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2023-12-19 11:40:57 Re: Synchronizing slots from primary to standby
Previous Message Fabrice Chapuis 2023-12-19 11:26:54 pg_waldump