yeah, we have a couple of patches that aren't good... And I kind of
lost track of it waiting for feedback on my last question.
It's not a must-fix, but it'd be good to get better messages eventually.
2010/2/26 Bruce Momjian <bruce(at)momjian(dot)us>:
> I assume we never came to any conclusion on this.
> Magnus Hagander wrote:
>> Tom Lane wrote:
>> > Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> >>> Answering myself here: the filesize for the "frontend only" part is
>> >>> about 2k on this system.
>> >> Long meeting, time for coding.. :-) Here's a rough patch. Is this about
>> >> what you had in mind?
>> > Hm, this seems to make the namespace pollution problem worse not better,
>> > because of de-staticizing so many functions. I guess we could stick pg_
>> > prefixes on all of them. That's a bit ugly; anybody have a better idea?
>> Not really.
>> > It might be that it'd be better to push a couple more of the simple
>> > path-munging functions (like join_path_components) over into the new
>> > file, so as to have a more logical division of responsibilities.
>> > In my mind the two key areas here are "path syntax knowledge" and
>> > "extracting absolute paths from environmental information". The second
>> > part seems to be the one that doesn't belong on the frontend side.
>> What would be the gain there? To be able to re-static-ify for example
>> skip_drive? Or just a nicer division?
>> We should probably also consider moving get_home_path() over to the
>> frontend one, and get rid of the copy that's in fe-connect.c.
>> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
> PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
> + If your life is a hard drive, Christ can be your backup. +
In response to
pgsql-hackers by date
|Next:||From: Tatsuo Ishii||Date: 2010-02-27 14:56:51|
|Subject: Re: Re: Hot Standby query cancellation and Streaming
Replication integration |
|Previous:||From: Bruce Momjian||Date: 2010-02-27 14:44:49|
|Subject: Re: Small change of the HS document|