Skip site navigation (1) Skip section navigation (2)

Re: Savepoints in PgAdmin

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-support(at)postgresql(dot)org, DUPREZ Cédric <cedric(dot)duprez(at)ifn(dot)fr>
Subject: Re: Savepoints in PgAdmin
Date: 2009-09-03 12:05:33
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-support
2009/9/3 Dave Page <dpage(at)pgadmin(dot)org>:
> On Thu, Sep 3, 2009 at 12:57 PM, Magnus Hagander<magnus(at)hagander(dot)net> wrote:
>> Good question. In general we shouldn't change the default behavior in
>> a backpatch, but I think the use-case for the current behavior is
>> pretty limited.
> It's not being back-patched. That code has been there for years, with
> only one complaint that I'm aware of. The complaint is a valid one
> though, which is why I think we should add the option for 1.12.
>> AIUI, nothing at all changes for single-statement queries, right? It
>> would only affect those that explicitly open a transaction. In which
>> case I think it's a reasonable default to behave the same way as psql,
>> which means change the default for pgadmin.
>> Specifically on the patch I don't like an option named "disabled auto
>> rollback". Negations in options suck. It shuold be "Enable auto
>> rollback", and then whatever the default is can be argued. I'd also
>> find it very useful if this was available as a checkbox on the query
>> menu, not just in the options dialog. Thoughts?
> Which would do what - override the default for that window only, or
> control the default as well? I prefer the former, but some of the
> other options are stored for all future query windows, so there may be
> some inconsistency there.

That's a good question. I'd say for that window only, yes, and perhaps
look over the other options to make them consistent?

 Magnus Hagander

In response to

pgadmin-support by date

Next:From: Guillaume LelargeDate: 2009-09-03 12:08:54
Subject: Re: Savepoints in PgAdmin
Previous:From: Dave PageDate: 2009-09-03 12:02:24
Subject: Re: Savepoints in PgAdmin

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group