Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on
Date: 2009-08-05 12:38:27
Message-ID: 9837222c0908050538m2667ca13hd134539ca4f82413@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 28, 2009 at 15:45, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Mon, Jul 27, 2009 at 16:14, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'm not really insisting on a redesign.  I'm talking about the places
>>> where the code author appears not to have understood that ERROR means
>>> FATAL, because the code keeps plugging on after it anyway.  As far as
>>> I can see, using ERROR at lines 3630, 3657, 3674, and 3693 is just
>>> plain bogus, and changing to LOG there requires no other fixing.
>
>> But. I'll look into cleaning those up for HEAD anyway, but due to lack
>> of reports I think we should skip backpatch. Reasonable?
>
> Fair enough.

Here's what I came up with. Seems ok?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

Attachment Content-Type Size
exec_errors.patch text/x-diff 7.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-05 13:12:57 Re: Re: [COMMITTERS] pgsql: Use DocBook XSL stylesheets for man page building This switches
Previous Message Michael Meskes 2009-08-05 11:42:20 pgsql: Fixed copyright notice.

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2009-08-05 13:02:13 Re: status of ECPG patches?
Previous Message Robert Haas 2009-08-05 12:08:02 status of ECPG patches?