From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | select_common_typmod |
Date: | 2020-10-20 08:58:18 |
Message-ID: | 97df3af9-8b5e-fb7f-a029-3eb7e80d7af9@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
While working on another patch, I figured adding a
select_common_typmod() to go along with select_common_type() and
select_common_collation() would be handy. Typmods were previously
combined using hand-coded logic in several places, and not at all in
other places. The logic in select_common_typmod() isn't very exciting,
but it makes the code more compact and readable in a few locations, and
in the future we can perhaps do more complicated things if desired.
There might have been a tiny bug in transformValuesClause() because
while consolidating the typmods it does not take into account whether
the types are actually the same (as more correctly done in
transformSetOperationTree() and buildMergedJoinVar()).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Add-select_common_typmod.patch | text/plain | 7.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-10-20 09:11:03 | Re: Online verification of checksums |
Previous Message | tsunakawa.takay@fujitsu.com | 2020-10-20 08:55:59 | RE: Transactions involving multiple postgres foreign servers, take 2 |