Skip site navigation (1) Skip section navigation (2)

Re: Sort is actually PlanState?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sort is actually PlanState?
Date: 2010-11-02 01:06:22
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
> I wonder why SortState is a ScanState. As far as I know ScanState
> means the node may need projection and/or qualification, or it scans
> some relation, but Sort actually doesn't do such things.

No, not really.  Per the comment for ScanState:

 *        ScanState extends PlanState for node types that represent
 *        scans of an underlying relation.  It can also be used for nodes
 *        that scan the output of an underlying plan node --- in that case,
 *        only ScanTupleSlot is actually useful, and it refers to the tuple
 *        retrieved from the subplan.

It might be that we don't actually need ScanTupleSlot right now in the
implementation of Sort, but I don't see a good reason to remove the
field.  We might just have to put it back later.

BTW, Sort is not the only node type like this --- I see at least
Material that's not projection-capable but has a ScanState.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Itagaki TakahiroDate: 2010-11-02 02:10:27
Subject: Re: Complier warnings on mingw gcc 4.5.0
Previous:From: Hitoshi HaradaDate: 2010-11-02 00:55:47
Subject: Sort is actually PlanState?

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group