Re: Use uppercase keywords in foreign key tutorial

From: Erik Wienhold <ewie(at)ewie(dot)name>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Use uppercase keywords in foreign key tutorial
Date: 2025-11-05 18:09:28
Message-ID: 971a5a3d-c200-4700-824b-f71a6e831994@ewie.name
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On 2025-11-04 03:09 +0100, David Rowley wrote:
> On Tue, 4 Nov 2025 at 13:04, Erik Wienhold <ewie(at)ewie(dot)name> wrote:
> >
> > On 2025-11-03 23:37 +0100, David Rowley wrote:
> > > I'm starting to wonder if adjusting the spacing here is a worthwhile
> > > change.
> >
> > I think it's worth to have that consistency. If the patch is too broad
> > I can of course limit it to the listings with inconsistent keyword
> > casing which is more less patch v2 plus some changes from v3 and later.
> >
> > Or just fix the keywords for now to get that out of the way and deal
> > with the spacing in a separate patch/thread.
>
> I think just the keyword upper casing is a good idea for now. I'm
> starting to lose hope that there's enough merit and consistency to the
> proposed whitespace changes. Maybe there's a subset of it that does
> make sense to do.

Done in the attached v6. But I kept the few whitespace changes on lines
where I change keywords to uppercase. It's mostly a single space after
commas in column and parameter lists which I think also enhances
readability.

--
Erik Wienhold

Attachment Content-Type Size
v6-0001-doc-Use-uppercase-keywords.patch text/plain 89.3 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message David Rowley 2025-11-06 03:06:01 Re: Use uppercase keywords in foreign key tutorial
Previous Message David Rowley 2025-11-04 02:09:56 Re: Use uppercase keywords in foreign key tutorial