|From:||Alexey Bashtanov <bashtanov(at)imap(dot)cc>|
|To:||Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>|
|Cc:||pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>|
|Subject:||Re: [patch] bit XOR aggregate functions|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Thanks for your reviews.
I've updated my patch to the current master and added a documentation
line suggesting using the new function as a checksum.
Best regards, Alex
On 04/03/2021 17:14, Ibrar Ahmed wrote:
> On Wed, Mar 3, 2021 at 7:30 PM Peter Eisentraut
> <mailto:peter(dot)eisentraut(at)enterprisedb(dot)com>> wrote:
> On 10.02.21 06:42, Kyotaro Horiguchi wrote:
> > We already had CREATE AGGREATE at the time, so BIT_XOR can be
> > as it falls into the same category with BIT_AND and BIT_OR, that is,
> > we may have BIT_XOR as an intrinsic aggregation?
> I think the use of BIT_XOR is quite separate from BIT_AND and BIT_OR.
> The latter give you an "all" or "any" result of the bits set.
> will return 1 or true if an odd number of inputs are 1 or true, which
> isn't useful by itself. But it can be used as a checksum, so it
> pretty reasonable to me to add it. Perhaps the use case could be
> pointed out in the documentation.
> Hi Alex,
> The patch is failing just because of a comment, which is already
> changed by another patch
> -/* Define to build with OpenSSL support. (--with-ssl=openssl) */
> +/* Define to 1 if you have OpenSSL support. */
> Do you mind sending an updated patch?
> I am changing the status to "Waiting for Author"
> In my opinion that change no more requires so I removed that and
> attached the patch.
> Ibrar Ahmed
|Next Messageemail@example.com||2021-03-05 12:56:25||RE: libpq debug log|
|Previous Message||Joel Jacobson||2021-03-05 12:42:19||Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range|