Re: executor relation handling

On 2018/09/28 17:21, David Rowley wrote:
> On 28 September 2018 at 20:00, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I've made minor tweaks, which find in
>> the attached updated patches (a .diff file containing changes from v6 to
>> v7 is also attached).
>
> Thanks for looking over the changes.
>
> I've looked at the v6 to v7 diff and it seems all good, apart from:
>
> + * The following asserts that the necessary lock on the relation
>
> I think we maybe should switch the word "assert" for "verifies". The
> Assert is just checking we didn't get a NoLock and I don't think
> you're using "assert" meaning the Assert() marco, so likely should be
> changed to avoid confusion.

Okay, I've revised the text in the attached updated patch.

> Apart from that, I see nothing wrong with the patches, so I think we
> should get someone else to look. I'm marking it as ready for
> committer.

Thanks for your time reviewing the patches.

Regards,
Amit