RE: [HACKERS] Issues with the latest 6.5 source

From: Michael J Davis <michael(dot)j(dot)davis(at)tvguide(dot)com>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-interfaces(at)postgreSQL(dot)org, pgsql-hackers(at)postgreSQL(dot)org
Subject: RE: [HACKERS] Issues with the latest 6.5 source
Date: 1999-04-29 01:26:13
Message-ID: 93C04F1F5173D211A27900105AA8FCFC145446@lambic.prevuenet.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-interfaces

Yea!!!!! This fixes the problem. I will test the \g option in a few hours
after I have completely repopulated my data. How about adding a comment
about the importance of this patch? Thanks Tom for tracking this down so
quickly.

Thanks, Michael

-----Original Message-----
From: Tom Lane [SMTP:tgl(at)sss(dot)pgh(dot)pa(dot)us]
Sent: Wednesday, April 28, 1999 4:29 PM
To: Michael J Davis
Cc: pgsql-interfaces(at)postgreSQL(dot)org;
pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Issues with the latest 6.5 source

Michael J Davis <michael(dot)j(dot)davis(at)tvguide(dot)com> writes:
> 1) The \g option in pgsql is failing.

Fixed. I had managed to break the empty-query response protocol on
Sunday --- odd that none of the regression tests detected this.
Sigh.

> 2) My Access97 application using ODBC can't connect to the
database.

I now have a strong suspicion that this is caused by the same goof.
ODBC might issue an empty query during startup. (That used to be a
necessary part of the startup protocol; it isn't anymore, but ODBC
very possibly hasn't been changed.)

If you don't have CVS access and don't want to wait for tonight's
snapshot, here is the patch:

*** src/backend/tcop/dest.c~ Wed Apr 28 18:15:07 1999
--- src/backend/tcop/dest.c Wed Apr 28 18:15:45 1999
***************
*** 336,342 ****
* tell the fe that we saw an
empty query string
* ----------------
*/
! pq_putbytes("I", 1);
break;

case Local:
--- 336,342 ----
* tell the fe that we saw an
empty query string
* ----------------
*/
! pq_putbytes("I", 2); /* note we send I and
\0 */
break;

case Local:

Let us know if that helps...

regards, tom lane

Browse pgsql-hackers by date

  From Date Subject
Next Message Atsushi Mano 1999-04-29 01:59:26
Previous Message Tom Lane 1999-04-28 22:29:18 Re: [HACKERS] Issues with the latest 6.5 source

Browse pgsql-interfaces by date

  From Date Subject
Next Message Constantin Teodorescu 1999-04-29 05:39:32 Re: [INTERFACES] RPM for PgAccess 0.96
Previous Message Massy Ghausi 1999-04-28 22:46:53 RPM for PgAccess 0.96