Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm
Date: 2010-01-03 09:55:05
Message-ID: 937d27e11001030155qa2524e9g32610cc7801a2550@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Sat, Jan 2, 2010 at 9:57 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> OK. Here is a new patch which calls PQconninfoParse and acts according
> to its return code. It also removes part of the old patch.
>
> Is it better?

Certainly looks more as I imagined. There is a little inconsistency though:

+ wxString applicationname = wxT("pgAdmin (Query Tool)");

...

+ wxString applicationname = wxT("pgAdmin - Query Tool");

Also, doesn't the debugger falback to the libc encoding as the main
connection class does?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2010-01-03 10:11:49 Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm
Previous Message Guillaume Lelarge 2010-01-02 21:57:39 Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm