| From: | Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
|---|---|
| To: | Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Subject: | Re: pgAdmin and Slony |
| Date: | 2009-09-03 13:28:18 |
| Message-ID: | 937d27e10909030628hbcd4afbg406f4cc4d2285e48@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Sep 3, 2009 at 2:08 PM, Sachin
Srivastava<sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
> Dave,
>
>> - bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)
>>
>> should be:
>>
>> bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)
>>
>
> Done.
>>
>> - Just reading the patch, it looks like we never try to load xxid*.sql
>> any more. That's surely wrong?
>>
>
> Yes. Attached is an updated patch.
Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
can you review it as well please?
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2009-09-03 13:37:25 | Re: pgAdmin and Slony |
| Previous Message | Sachin Srivastava | 2009-09-03 13:08:22 | Re: pgAdmin and Slony |