Re: Small annoyance in pgAdmin 1.10

On Mon, Aug 10, 2009 at 2:02 PM, Ashesh
Vashi<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Guillaume,
>
> Guillaume Lelarge wrote:
>
> Le lundi 10 août 2009 à 14:49:21, Dave Page a écrit :
>
> On Mon, Aug 10, 2009 at 1:44 PM, Guillaume
>
> Lelarge<guillaume(at)lelarge(dot)info> wrote:
>
> Here is a patch that should fix this. Magnus, care to check it? I'm not
> ready to commit it without proper review. It plays with pointers, and
> that scares me a bit :)
>
> Passing a pointer to a wxString around is *always* wrong. It can futz
> with the internal reference counting.
>
> If I can't use a pointer, I don't see how I can do this. Or should I just
> remove the MessageBox?
>
> As per my understanding, you always can use reference in place of pointer.

Yes, just pass by reference:

bool generateSQL(const wxString &query);

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com