Re: Patch to fix Debian Bug #451038

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Patch to fix Debian Bug #451038
Date: 2009-08-06 16:14:01
Message-ID: 937d27e10908060914r2e2256c8tb7afac5a72c294a3@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Sorry - please go ahead. I'm sure it's fine.

I'm trying to rely more on the other senior devs these days - it's
hard to find time to check every patch, and you've shown long ago that
your standard of work is at least as high as mine, probably much
higher :-)

Lelarge <guillaume(at)lelarge(dot)info> wrote:
> Le jeudi 23 juillet 2009 à 22:37:18, Guillaume Lelarge a écrit :
>> Le jeudi 23 juillet 2009 à 21:18:22, Guillaume Lelarge a écrit :
>> > Le jeudi 23 juillet 2009 à 21:09:26, Magnus Hagander a écrit :
>> > > On Thu, Jul 23, 2009 at 20:56, Dave Page<dpage(at)pgadmin(dot)org> wrote:
>> > > > On Thu, Jul 23, 2009 at 6:48 PM, Guillaume
>> > > >
>> > > > Lelarge<guillaume(at)lelarge(dot)info> wrote:
>> > > >> So here is a patch to fix this.
>> > > >
>> > > > Should we filter on *.* on Windows, and just * everywhere else?
>> > > > It'll
>> > > > make the code a little messier, but would make more sense to the
>> > > > user.
>> > >
>> > > +1 - it'll be much nicer for the user I think.
>> >
>> > OK, if you're two to think the same, I'll change my patch.
>>
>> Here it is.
>
> No comments on this. I suppose it's good enough? Can I commit it?
>
>
> --
> Guillaume.
> http://www.postgresqlfr.org
> http://dalibo.com
>

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2009-08-06 20:35:58 SVN Commit by guillaume: r8008 - in trunk/pgadmin3: . pgadmin/frm
Previous Message pgAdmin Trac 2009-08-06 15:55:28 [pgAdmin III] #39: Guru Hints are empty