| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch for Caching datatypes for dlgColumn |
| Date: | 2009-07-07 13:28:49 |
| Message-ID: | 937d27e10907070628h3bcbbf8ck86d7f89f9439456c@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Jul 6, 2009 at 10:32 AM, Sachin
Srivastava<sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
> Hi all,
>
> For the TODO item:
>
> * Cache datatypes used by dlgColumn as reloading them when adding multiple
> columns to a new table can be slow over WANs.
>
> Attached is a patch for it. Please give your comments on it.
Thanks, patch applied. I made a couple of minor changes - it was
suffering from type/module variable/function parameter naming
confusion. It now uses 'dataTypeCache' for the type, 'dtCache' for the
module variables, and 'cache' for the function parameters.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | svn | 2009-07-07 21:29:30 | SVN Commit by guillaume: r7966 - in trunk/pgadmin3: . pgadmin/utils |
| Previous Message | svn | 2009-07-07 13:27:01 | SVN Commit by dpage: r7965 - in trunk/pgadmin3: . pgadmin/dlg pgadmin/include/dlg |