From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Chuck McDevitt <cmcdevitt(at)greenplum(dot)com> |
Cc: | "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: New patch for bugs in GPDB csv format log handling |
Date: | 2009-06-08 13:03:26 |
Message-ID: | 937d27e10906080603y1ca0b8f3w37a700ca572325c2@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Jun 5, 2009 at 3:40 AM, Chuck McDevitt<cmcdevitt(at)greenplum(dot)com> wrote:
> This patch fixes many problems in the handling of GPDB CSV format logs for the frmStatus display.
>
> It's also a useful start for supporting PostgreSQL 8.4 CSV format logs.
Hi,
Some issues with this, 2 minor, one less so:
- Please rearrange the code in frmStatus.h to remove the class
definition. We try to keep the headers purely for declarations and
only include one-line functions in them. I would suggest a new file in
utils/ given that it's a generally useful class.
- Status bar messages such as _("Reading log from server.") should
generally end with ... to indicate the task is ongoing.
- Messages passed to wxLogError should be translatable, and explain
the problem to the user without being phrased as a question (wxT("Log
line does not start with timestamp?: %s \n")). Messages passed to
wxLogNotice needn't be translated however.
Regards, Dave.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Chuck McDevitt | 2009-06-08 21:02:32 | Re: New patch for bugs in GPDB csv format log handling |
Previous Message | svn | 2009-06-08 12:45:54 | SVN Commit by dpage: r7898 - trunk/pgadmin3/pgadmin/dlg |