Re: pgsql: Append major version number and for libraries soname major

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Append major version number and for libraries soname major
Date: 2008-12-16 10:13:01
Message-ID: 937d27e10812160213j6317d803gfaf036fbb6d5de27@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Dec 12, 2008 at 12:41 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>> Log Message:
>> -----------
>> Append major version number and for libraries soname major version number
>> to the gettext domain name, to simplify parallel installations.
>
> The results from buildfarm member red_bat suggest that this commit broke
> the MSVC build. (I think that is the only MSVC buildfarm member that's
> up at the moment.)
>
> Build FAILED.
> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
> .\src\backend\main\main.c(90): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
> 0 Warning(s)
> 3 Error(s)

Any eta on a fix for this? My internal builds are failing as well as
red_bat. (and yes, the other 2 MSVC buildfarm members are currently
waiting for Dell to get hold of a new motherboard for their box).

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2008-12-16 10:47:43 Re: pgsql: Append major version number and for libraries soname major
Previous Message Bruce Momjian 2008-12-16 03:12:09 pgsql: Fix wording of section comparing triggers and rules; old wording

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-12-16 10:21:10 Re: Sync Rep: First Thoughts on Code
Previous Message Shri 2008-12-16 10:05:47 non unique value error... pgsql,,help needed.