Skip site navigation (1) Skip section navigation (2)

Re: new patch for index DESC/NULLS FIRST/NULLS LAST

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Quan Zongliang" <quanzongliang(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: new patch for index DESC/NULLS FIRST/NULLS LAST
Date: 2008-11-25 12:49:23
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
On Sat, Nov 22, 2008 at 10:43 AM, Quan Zongliang
<quanzongliang(at)gmail(dot)com> wrote:
>> That code could use some formatting changes though
>> We also try to leave empty lines between distinct blocks of code to
>> aid readability.
> Done.
>> - lstColumns should always display the order and nulls values
>> - The NULLs radio buttons should not have a shaded box around them.
>> - I think the dialogue design would look nicer if the DESC and and
>> NULLs options were on the same horizontal alignment, eg:
>> DESC []        NULLs    O FIRST    O LAST
> Done.

Thanks - patch applied with minor tweaks to the horizontal layout, and
to ensure we always have a direction selected, so it's clear what the
user will get.

>> - When creating an index with one column, using DESC, I clicked on the
>> SQL tab and got an assert:
> I don't get it in Windows XP.
> Maybe, when there is default value, my code don't invoke wxListView's
> SetItem() and left original value. Is it NULL in Mac?

Looks like it was an existing bug that I hadn't spotted before - I've
fixed it in SVN. Sorry for the noise.

Thanks again for the patch!

Dave Page
EnterpriseDB UK:

In response to

pgadmin-hackers by date

Next:From: svnDate: 2008-11-25 13:22:21
Subject: SVN Commit by dpage: r7506 - trunk/pgadmin3/pgadmin/dlg
Previous:From: Dave PageDate: 2008-11-25 11:35:44
Subject: Re: pgAgent 2.0.0 compilation errors (types casting)

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group