Re: Buglets in dlgFunction

On Thu, Oct 2, 2008 at 12:05 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Dave Page a écrit :
>> [...]
>> I found a couple of small bugs in the new layout code for dlgFunction:
>>
>> - The Privileges (and SQL) panes don't size themselves properly when
>> viewing an existing function, until the dialogue is manually resized
>> - The privilege checkboxes are touching the role combo box above.
>>
>> I've attached a screenshot for your amusement :-)
>>
>
> I finally found some time to work on this... You'll find a patch
> attached. It seems to work nice on Mac and Linux. Can you check on your
> Mac ? Thanks.
>
> I would love this to be the solution. This hack would allow us to get
> rid of the 350 constant in the OnSize method.

Testing dlgFunction:

The SQL pane seems OK now, but the privileges pane opens with the
controls at a minimal size on the parent pane, and the listview still
has the non-shrinking bug :-(. I've attached screenshots.

Testing dlgTable, dlgSequence:

(create mode) SQL pane is fine. Initial size of the privileges
controls are fine, just the listview bug remaining. (edit mode)
pgAdmin crashes.

Testing dlgDatabase:

SQL pane is fine. Initial size of the privileges controls are fine,
just the listview bug remaining.

Testing dlgPackage:

SQL pane is fine. Initial sizing of the privilege controls is broken.
The listview bug is not present.

Testing dlgTablespace, dlgSchema, dlgView:

Work perfectly :-)

So it seems like all bugs are fixed somewhere, just not on all dialogues!

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com