Re: First public pre-alpha release of GQB (Graphical Query Builder) for pgAdmin

[Please keep list message on-list]

On Tue, Aug 5, 2008 at 1:35 PM, Luis Ochoa <ziul1979(at)gmail(dot)com> wrote:

>> - The tables are *really* small on OSX. See screenshot 2. Consider
>> using the user-configurable font or SQL font options.
>
> What do you think about allowing user just to change font size?
> In what part of the menu you think this should be add?

That's why I suggested using the existing configurable options. See:

wxFont sysSettings::GetSystemFont();
wxFont sysSettings::GetSQLFont();

The system font is the one used in most controls, the SQL font is used
in ctlSQLBox's (and is usually fixed-width). Both have sensible
defaults on all platforms.

>> - You need to tweak the default views to enlarge the toolbar size on
>> frmQuery to account for the additional button (see frmQuery.h iirc).
>> The button should be placed in a more appropriate place - certainly
>> not after the help button which is always last.
>
> Ok, but after complete all other things [ something like lower priority :)
> ] my list of todo things is really big :'(

Yup, of course.

>> Should look more like:
>>
>> SELECT
>> *
>> FROM
>> pg_class,
>> pg_attribute
>> WHERE
>> pg_attribute.attrelid = pg_class.relname AND
>> pg_class.relname = 'pg_class';
>
> Ok, I believe that the option to generate joins of kind "a.x=b.x" or "a
> join b on (a.x=b.x)" should be added to.

Yes, that syntax will be needed for left/right outer joins etc. - my
comment was more about tidying the general formatting to be more in
line with what we have elsewhere though.

>> - The 'Selected Columns' and 'Columns Criteria' tabs still need to be
>> moved onto the GQB tab (as you already know :-) ).
>
> Yes, but afraid of new bugs on linux/mac when this will be done :'(.... but
> have to be done...

Yes - oh, and that reminds me - the vertical splitter only resizes the
drawing area, not the treeview. I guess this is the splitter bug you
mentioned in you earlier email? You should be able to get that to work
OK - we used to use splitters everywhere before changing to wxAUI.

>> - The column headers on the two tabs are of different heights.
>
> In SQL Editor | GQB tabs?
>
> or in bottom tabs?

Sorry, the column headers of the grids on the bottom tabs.

/D

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com