| From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> |
| Subject: | Re: Exposing keywords to clients |
| Date: | 2008-05-03 20:44:58 |
| Message-ID: | 937d27e10805031344n440e5ea5mbff6f5cda9d548f9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Sat, May 3, 2008 at 9:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Dave Page" <dpage(at)pgadmin(dot)org> writes:
> > Attached is an updated patch, giving the following output.
>
> Oh, one other thing: dropping externs into random modules unrelated to
> their source module is completely awful programming style, because there
> is nothing preventing incompatible declarations. Put those externs in
> keywords.h instead.
OK.
> I suspect you have ignored a compiler warning
> about not declaring pg_get_keywords itself, too --- it should be
> extern'd in builtins.h.
No, no warning (I'm using VC++ today) - but fixed anyway.
Update attached, including corrected docs. Note to self - proof read
docs *after* putting the kids to bed in future.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| pg_get_keywords-3.diff | text/plain | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2008-05-03 23:35:37 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
| Previous Message | Tom Lane | 2008-05-03 20:06:54 | Re: Exposing keywords to clients |