On Sat, May 3, 2008 at 9:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Dave Page" <dpage(at)pgadmin(dot)org> writes:
> > Attached is an updated patch, giving the following output.
> Oh, one other thing: dropping externs into random modules unrelated to
> their source module is completely awful programming style, because there
> is nothing preventing incompatible declarations. Put those externs in
> keywords.h instead.
> I suspect you have ignored a compiler warning
> about not declaring pg_get_keywords itself, too --- it should be
> extern'd in builtins.h.
No, no warning (I'm using VC++ today) - but fixed anyway.
Update attached, including corrected docs. Note to self - proof read
docs *after* putting the kids to bed in future.
EnterpriseDB UK: http://www.enterprisedb.com
In response to
pgsql-patches by date
|Next:||From: Andrew Dunstan||Date: 2008-05-03 23:35:37|
|Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected
|Previous:||From: Tom Lane||Date: 2008-05-03 20:06:54|
|Subject: Re: Exposing keywords to clients |