Re: Display line numbers in SQL view

On Sat, Mar 15, 2008 at 2:43 AM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
> Hi Dave,
>
> True. In that case moving it as an option (with sane defaults) did seem like
> a better way. So attached is a reworked patch that puts two options in
> frmOptions.
>
> 1. A checkbox (in preferences tab) that applies to line numbers universally.
> 2. One checkbox (in the Query tab) specific to the SQL Query window.
>
> The defaults ensure that the we maintain status quo (i.e. Line numbers are
> enabled for Functions/Triggers but disabled for Query window).

Hmm, sorry, that still irks me. How about we just have 2 independent
options, one for dialogues, and one for windows (the query tool and
debugger)? We have various other options actually on the Query Tool
(because it can be run standalone), so the window option should
probably be included there as well.

Unless you want to incorporate this change into a wider change to move
all options onto frmOptions, and allow the appropriate parts of that
to be access from the Query Tool? That's what I'd like to see if you
want to work on it.

--
Dave Page
EnterpriseDB UK Ltd: http://www.enterprisedb.com
PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk