Re: [PATCH] Add a few suppression rules for Valgrind

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add a few suppression rules for Valgrind
Date: 2018-02-20 17:39:37
Message-ID: 9335.1519148377@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
>> I decided to run the code from master branch under Valgrind and
>> discovered that it reports some errors.

> On my systems I just include a global valgrind suppression file which
> includes libc specific things and then the postgres valgrind.supp. I'm
> very hesitant to add suppressions to the codebase for this, seems too
> likely to actually hide bugs.

Yeah, I think it's a much better idea to add a local suppression file
for problems in your local libc or other libraries. That's what I do.
Looking at mine, it also suppresses some weirdnesses in RHEL6's version
of Perl, which would surely be inappropriate on other platforms.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-02-20 17:43:45 Re: ALTER TABLE ADD COLUMN fast default
Previous Message Tom Lane 2018-02-20 17:32:22 Re: Option to ensure monotonic timestamps