|From:||Lars Kanis <lars(at)greiz-reinsdorf(dot)de>|
|To:||Michael Paquier <michael(at)paquier(dot)xyz>|
|Subject:||Re: libpq: Fix wrong connection status on invalid "connect_timeout"|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Am 18.10.19 um 05:06 schrieb Michael Paquier:
> So attached is a patch to skip trailing whitespaces as well,
> which also fixes the issue with ECPG. I have refactored the parsing
> logic a bit while on it. The comment at the top of parse_int_param()
> needs to be reworked a bit more.
I tested this and it looks good to me. Maybe you could omit some
redundant 'end' checks, as in the attached patch. Or was your intention
to verify non-NULL 'end'?
> Perhaps we could add directly regression
> tests for libpq. I'll start a new thread about that once we are done
> here, the topic is larger.
We have around 650 tests on ruby-pg to ensure everything runs as
expected and I always wondered how the API of libpq is being verified.
|Next Message||Amit Kapila||2019-10-18 12:01:58||Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions|
|Previous Message||Corey Huinker||2019-10-18 11:54:18||Add Change Badges to documentation|