Re: Declarative partitioning - another take

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Erik Rijkers <er(at)xs4all(dot)nl>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: Declarative partitioning - another take
Date: 2017-01-19 11:23:55
Message-ID: 92fe2a71-5eb7-ee8d-53ef-cfd5a65dfc3d@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2017/01/19 14:15, Amit Langote wrote:
> So, here are all the patches I posted to date (and one new at the bottom)
> for reported and unreported bugs, excluding the one involving
> BulkInsertState for which you replied in a new thread.
>
> I'll describe the attached patches in brief:

Sorry, I forgot to mention that I have skipped the patch I proposed to
modify the committed approach [1] to get the correct tuple to show in the
constraint violation messages. It might be better to continue that
discussion at [2].

And because I skipped that patch, I should have removed the related logic
in ExecWithCheckOptions() that I added in one of the later patches (patch
0004), which I forgot to do. So, here are all the patches again with the
correct 0004 this time. Sigh.

Thanks,
Amit

[1]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f1b4c771ea74f42447dccaed42ffcdcccf3aa694

[2]
https://www.postgresql.org/message-id/CA%2BTgmoZjGzSM5WwnyapFaw3GxnDLWh7pm8Xiz8_QWQnUQy%3DSCA%40mail.gmail.com

Attachment Content-Type Size
0001-Fix-a-bug-of-insertion-into-an-internal-partition.patch text/x-diff 6.7 KB
0002-Set-ecxt_scantuple-correctly-for-tuple-routing.patch text/x-diff 4.6 KB
0003-Fix-RETURNING-to-work-correctly-after-tuple-routing.patch text/x-diff 9.8 KB
0004-Fix-some-issues-with-views-and-partitioned-tables.patch text/x-diff 5.6 KB
0005-Fix-some-wrong-thinking-in-check_new_partition_bound.patch text/x-diff 8.0 KB
0006-Avoid-code-duplication-in-map_partition_varattnos.patch text/x-diff 1.9 KB
0007-Avoid-tuple-coversion-in-common-partitioning-cases.patch text/x-diff 4.9 KB
0008-Avoid-DROP-TABLE-.-CASCADE-in-more-partitioning-test.patch text/x-diff 5.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2017-01-19 11:31:54 Re: Vacuum: allow usage of more than 1GB of work mem
Previous Message Antonin Houska 2017-01-19 11:22:25 Re: PoC: Grouped base relation