Re: PATCH: Unlogged tables re-initialization tests

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: PATCH: Unlogged tables re-initialization tests
Date: 2018-03-05 17:35:35
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 3/1/18 11:59 PM, Michael Paquier wrote:
> On Thu, Mar 01, 2018 at 01:12:19PM -0500, David Steele wrote:
>> But your point is well-taken. No symlinks are used in this test so it
>> *should* work.
>> Michael, what do you think?
> Perl's symlink() does not work on Windows. It does not fly higher than
> that, and that's the reason why a good chunk of the tests are skipped
> for pg_basebackup. If perl was to have a version of symlink() which
> works, say with junction points, or if Windows was to have a sane
> symlink implementation (or with [1]?), or if it was possible to create
> junction points using an in-core implementation in perl, then those
> tests could not be skipped. But it seems that none of those scenarios
> have happened yet.
> From what I read in your patch, it seems to me that this test should
> work. If they don't for whatever reason, your patch then does not give
> a correct justification explaining why they should be skipped.

Thanks for the input, Michael.

Attached is a new version that does not skip tests on Windows. I don't
have any way to test it, but if one of you do that would be much


Attachment Content-Type Size
recovery-reinit-unlogged-test-v2.patch text/plain 4.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-03-05 18:20:16 Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative
Previous Message Alvaro Herrera 2018-03-05 17:25:39 Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?