| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Michael Paquier" <michael(at)paquier(dot)xyz> |
| Cc: | "Aleksander Alekseev" <aleksander(at)tigerdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Peter Eisentraut" <peter(at)eisentraut(dot)org> |
| Subject: | Re: change default default_toast_compression to lz4? |
| Date: | 2026-02-19 16:12:09 |
| Message-ID: | 92ed55b6-6b69-42d9-8697-3e51603e961d@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 4, 2025, at 11:23 PM, Michael Paquier wrote:
>
> So this had better be adjusted in one go, in the shape of a tweak in
> mingw_cross_warning_script with the addition of a --without-lz4, same
> way as for ICU.
>
Done.
> Hmm. It seems to me that we should just set not_found_dep if lz4
> cannot be found, leaving meson_options.txt as it is currently, no?
>
Done.
Changes from last version:
- adjust CI
- set not_found_dep instead of warning message
- remove quotes from default_toast_compression value
It is aligned with ICU and readline behavior.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Change-default_toast_compression-to-lz4.patch | text/x-patch | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-02-19 16:13:41 | Re: add assertion for palloc in signal handlers |
| Previous Message | Nathan Bossart | 2026-02-19 16:08:20 | Re: convert SpinLock* macros to static inline functions |