Re: [PATCH] Implement INSERT SET syntax

From: Gareth Palmer <gareth(at)internetnz(dot)net(dot)nz>
To: movead li <movead(dot)li(at)highgo(dot)ca>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Implement INSERT SET syntax
Date: 2020-04-24 00:04:33
Message-ID: 9253E61F-A278-40B4-AC24-F571C48F4181@internetnz.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Movead,

> On 22/04/2020, at 2:40 PM, movead li <movead(dot)li(at)highgo(dot)ca> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> It builds failed by applying to the latest code version, and I try head
> '73025140885c889410b9bfc4a30a3866396fc5db' which work well.
>
> The new status of this patch is: Waiting on Author

Thank you for the review, attached is v7 of the patch which should
apply correcly to HEAD.

This version now uses it's own production rule for the SET clause to
avoid the issue with MultiAssigmentRef nodes in the targetList.

Attachment Content-Type Size
insert-set-v7.patch application/octet-stream 14.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-04-24 00:44:08 Re: xid wraparound danger due to INDEX_CLEANUP false
Previous Message Michael Paquier 2020-04-23 23:54:02 Re: [BUG] non archived WAL removed during production crash recovery