Skip site navigation (1) Skip section navigation (2)

Re: contrib/pg_stat_statements 1226

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, "Alex Hunsaker" <badalex(at)gmail(dot)com>
Subject: Re: contrib/pg_stat_statements 1226
Date: 2009-01-03 20:14:25
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> "Alex Hunsaker" <badalex(at)gmail(dot)com> wrote:
>> How about just pg_stat_statements.track ?

> I renamed the variables to:
>     - pg_stat_statements.limit
>     - pg_stat_statements.track
>     - pg_stat_statements.saved_file

Hmm, this has got a problem:

regression=# show pg_stat_statements.limit ;
ERROR:  syntax error at or near "limit"
LINE 1: show pg_stat_statements.limit ;

LIMIT is a reserved word ...

I thought max_statements was fine, but if people think that's too long
I guess we could go with just "max".

I'm not enamored of "saved_file" either, it seems like the wrong
part of speech somehow.  Maybe "save_in_file"?

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Magnus HaganderDate: 2009-01-03 20:16:49
Subject: Re: reloptions and toast tables
Previous:From: Tom LaneDate: 2009-01-03 20:00:52
Subject: Re: Custom PGC_POSTMASTER GUC variables ... feasible?

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group