Re: pgsql-server/src/timezone pgtz.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src/timezone pgtz.h
Date: 2004-05-01 01:34:48
Message-ID: 9036.1083375288@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h:

> #ifndef HAVE_SYMLINK
> #define HAVE_SYMLINK 0
> #endif

Surely this is exactly the wrong thing to do. It will break code that
tests for #ifdef HAVE_SYMLINK. Shouldn't you instead fix the timezone
library to make its tests in a more standard way?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-01 01:36:11 Re: pgsql-server/src/timezone pgtz.h
Previous Message Bruce Momjian 2004-05-01 01:34:47 pgsql-server/src/timezone pgtz.c pgtz.h