| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <momjian(at)postgresql(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove tabs in SGML. |
| Date: | 2010-01-27 17:27:08 |
| Message-ID: | 9027.1264613228@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
David Fetter <david(at)fetter(dot)org> writes:
> On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
>> Better write a check in the makefile.
> That assumes that everyone will always actually run the appropriate
> make before committing, which I wouldn't assume, especially for a
> "trivial" patch that's going out when someone is pressed for time.
> Checking in an unavoidable place seems much more foolproof.
The rule against tabs in SGML files is only a bit of anal retentivity
anyway. I don't think that enforcing it is worth special hacks that
we do not use anywhere else.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2010-01-27 17:30:03 | Re: [COMMITTERS] pgsql: Remove tabs in SGML. |
| Previous Message | David Fetter | 2010-01-27 17:04:06 | Re: [COMMITTERS] pgsql: Remove tabs in SGML. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2010-01-27 17:30:03 | Re: [COMMITTERS] pgsql: Remove tabs in SGML. |
| Previous Message | Tom Lane | 2010-01-27 17:08:48 | Re: Add on_perl_init and proper destruction to plperl [PATCH] |