| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Getting rid of OverrideSearhPath in namespace.c |
| Date: | 2023-07-16 10:00:00 |
| Message-ID: | 8ffb4650-52c4-6a81-38fc-8f99be981130@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello hackers,
As a follow-up for the CVE-2023-2454 fix, I think that it makes sense to
completely remove unsafe functions
PushOverrideSearchPath()/PopOverrideSearchPath(), which are not used in the
core now.
Please look at the patch attached.
Beside that, maybe it's worth to rename three functions in "Override" in
their names: GetOverrideSearchPath(), CopyOverrideSearchPath(),
OverrideSearchPathMatchesCurrent(), and then maybe struct OverrideSearchPath.
Noah Misch proposed name GetSearchPathMatcher() for the former.
What do you think?
Best regards,
Alexander
| Attachment | Content-Type | Size |
|---|---|---|
| v1-01-get-rid-of-PPOverrideSearchPath.patch | text/x-patch | 13.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2023-07-16 11:24:06 | Re: Should we remove db_user_namespace? |
| Previous Message | Andres Freund | 2023-07-16 01:56:56 | Improve heapgetpage() performance, overhead from serializable |