[patch] psql tab completion for grant execute

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [patch] psql tab completion for grant execute
Date: 2015-08-17 21:07:12
Message-ID: 8fb1c784-5082-41a9-b2ea-4da50c43225d@mm
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


When tab-completing after GRANT EXECUTE, currently psql injects
"PROCEDURE", rather than the expected "ON".

The code for completing with "ON" is there, but it's not reached due to
falling earlier into another branch, one that handles CREATE TRIGGER.

A trivial patch is attached. It adds the condition that if EXECUTE is
preceded by GRANT itself preceded by nothing, then that completion
with PROCEDURE is skipped.

I've looked at fixing it more directly, by testing if the EXECUTE
is part of a CREATE TRIGGER, but it didn't seem fitting to go
looking backwards that many words into the string (more
than the 5 words suggested by the rest of the code).

Best regards,
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

Attachment Content-Type Size
patch-psql-complete-grant.diff text/x-patch 556 bytes


Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-08-17 21:18:19 Re: jsonb array-style subscripting
Previous Message Merlin Moncure 2015-08-17 20:51:37 Re: jsonb array-style subscripting