|From:||Heikki Linnakangas <hlinnaka(at)iki(dot)fi>|
|To:||John Naylor <john(dot)naylor(at)enterprisedb(dot)com>|
|Subject:||Re: Perform COPY FROM encoding conversions in larger chunks|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 09/02/2021 19:36, Heikki Linnakangas wrote:
> On 09/02/2021 15:40, John Naylor wrote:
>> On Sun, Feb 7, 2021 at 2:13 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi
>> <mailto:hlinnaka(at)iki(dot)fi>> wrote:
>> > On 02/02/2021 23:42, John Naylor wrote:
>> > >
>> > > In copyfromparse.c, this is now out of date:
>> > >
>> > > * Read the next input line and stash it in line_buf, with
>> conversion to
>> > > * server encoding.
>> This comment for CopyReadLine() is still there. Conversion already
>> happened by now, so I think this comment is outdated.
>> Other than that, I think this is ready for commit.
> Fixed. And also fixed one more bug in allocating raw_buf_size, the "+ 1"
> somehow went missing again. That was causing a failure on Windows at
> I'll read through this one more time with fresh eyes tomorrow or the day
> after, and push. Thanks for all the review!
|Next Message||Robert Haas||2021-02-09 18:38:15||Re: repeated decoding of prepared transactions|
|Previous Message||Bossart, Nathan||2021-02-09 17:43:55||Re: Add MAIN_RELATION_CLEANUP and SECONDARY_RELATION_CLEANUP options to VACUUM|