Re: Perform COPY FROM encoding conversions in larger chunks

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Perform COPY FROM encoding conversions in larger chunks
Date: 2021-02-09 17:44:46
Message-ID: 8f2b028b-dd41-d0ac-1e6a-32eddb2f91aa@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/02/2021 19:36, Heikki Linnakangas wrote:
> On 09/02/2021 15:40, John Naylor wrote:
>> On Sun, Feb 7, 2021 at 2:13 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi
>> <mailto:hlinnaka(at)iki(dot)fi>> wrote:
>> >
>> > On 02/02/2021 23:42, John Naylor wrote:
>> > >
>> > > In copyfromparse.c, this is now out of date:
>> > >
>> > >   * Read the next input line and stash it in line_buf, with
>> conversion to
>> > >   * server encoding.
>>
>> This comment for CopyReadLine() is still there. Conversion already
>> happened by now, so I think this comment is outdated.
>>
>> Other than that, I think this is ready for commit.
>
> Fixed. And also fixed one more bug in allocating raw_buf_size, the "+ 1"
> somehow went missing again. That was causing a failure on Windows at
> cfbot.cputube.org.
>
> I'll read through this one more time with fresh eyes tomorrow or the day
> after, and push. Thanks for all the review!

Forgot attachment..

- Heikki

Attachment Content-Type Size
v5-0001-Add-noError-argument-to-encoding-conversion-funct.patch text/x-patch 225.1 KB
v5-0002-Do-COPY-FROM-encoding-conversion-verification-in-.patch text/x-patch 39.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-02-09 18:38:15 Re: repeated decoding of prepared transactions
Previous Message Bossart, Nathan 2021-02-09 17:43:55 Re: Add MAIN_RELATION_CLEANUP and SECONDARY_RELATION_CLEANUP options to VACUUM