Re: New GUC to sample log queries

From: Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New GUC to sample log queries
Date: 2018-11-21 08:06:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 11/19/18 2:52 PM, Dmitry Dolgov wrote:
>> On Mon, Nov 19, 2018 at 2:40 PM Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>> On 11/19/18 2:57 AM, Michael Paquier wrote:
>>> On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
>>>> Since it's hard to come up with a concise name that will mention sampling rate
>>>> in the context of min_duration_statement, I think it's fine to name this
>>>> configuration "log_sample_rate", as long as it's dependency from
>>>> log_min_duration_statements is clearly explained in the documentation.
>>> log_sample_rate looks fine to me as a name.
>> That seems far too short to me - the name should indicate it applies to
>> statement logging. I'd say log_statement_sample_rate is better.
> I agree, sounds reasonable.

Thanks for your comments. Here is the updated patch. I fixed a warning for
missing parentheses in this expression:
if ((exceeded && in_sample) || log_duration)

It passed make check_world and make docs

Attachment Content-Type Size
sample_rate-5.patch text/x-patch 4.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Adrien Nayrat 2018-11-21 08:09:36 Re: ALTER INDEX ... ALTER COLUMN not present in dump
Previous Message David Rowley 2018-11-21 08:05:59 Re: Speeding up INSERTs and UPDATEs to partitioned tables