Re: Improve error handling of HMAC computations and SCRAM

From: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improve error handling of HMAC computations and SCRAM
Date: 2022-01-12 23:01:24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 12.01.2022 14:32, Michael Paquier wrote:
> On Wed, Jan 12, 2022 at 12:56:17PM +0900, Michael Paquier wrote:
>> Attached is a rebased patch for the HMAC portions, with a couple of
>> fixes I noticed while going through this stuff again (mostly around
>> SASLprep and pg_fe_scram_build_secret), and a fix for a conflict
>> coming from 9cb5518. psql's \password is wrong to assume that the
>> only error that can happen for scran-sha-256 is an OOM, but we'll get
>> there.
> With an attachment, that's even better. (Thanks, Daniel.)
Gave it a thorough read. Looks good, except for errstr not set in a
couple of places (see the diff attached).

Didn't test it.

Sergey Shinderuk

Attachment Content-Type Size
errstr-not-set.txt text/plain 1.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-01-12 23:40:00 Re: Stream replication test fails of cfbot/windows server 2019
Previous Message Tomas Vondra 2022-01-12 22:43:04 Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path