Re: Reorganize collation lookup time and place

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andreas Karlsson <andreas(at)proxel(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reorganize collation lookup time and place
Date: 2018-12-12 17:48:35
Message-ID: 8cab119a-3406-5144-e577-4a981f5a5069@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/12/2018 15:58, Andreas Karlsson wrote:
> But when taking a look at your patch I got a segfault when running
> initdb. See the stack trace below. My compiler is "gcc (Debian 8.2.0-9)
> 8.2.0" and the locale when running initdb is glibc's "en_US.utf8".

Fixed in the attached updated patch.

(Apparently passing a NULL locale to strcoll_l() doesn't crash as
readily on macOS as on glibc.)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v2-0001-Reorganize-collation-lookup-time-and-place.patch text/plain 213.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-12-12 17:53:44 Re: [HACKERS] Can ICU be used for a database's default sort order?
Previous Message Alvaro Herrera 2018-12-12 17:21:29 Re: Cache lookup errors with functions manipulation object addresses