| From: | "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode |
| Date: | 2026-03-17 21:37:39 |
| Message-ID: | 8c47083ca3833a5a22ea8ced7ce54812eee59324.camel@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello!!
On Tue, 2026-03-17 at 06:41 +0000, Zsolt Parragi wrote:
> Hello
>
> These variables are still not freed, I am missing something why it
> isn't required?
>
> + char *oauth_ca_file; /* CA file path */
>
> Shouldn't we free this in freePGconn?
>
>
> + char *ca_file; /* oauth_ca_file */
>
> Similarly with free_async_ctx?
I totally miss this comments, and I had it noted
Attaching v5
--
Jonathan Gonzalez V.
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-libpq-oauth-allow-changing-the-CA-when-not-in-deb.patch | text/x-patch | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-17 21:38:45 | Re: Need help debugging SIGBUS crashes |
| Previous Message | Tom Lane | 2026-03-17 21:33:31 | Avoiding memory leakage in jsonpath evaluation |