| From: | "Mikheev, Vadim" <vmikheev(at)SECTORBASE(dot)COM> |
|---|---|
| To: | "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jan Wieck <JanWieck(at)Yahoo(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | RE: Re: [COMMITTERS] TOAST |
| Date: | 2000-07-04 02:45:55 |
| Message-ID: | 8F4C99C66D04D4118F580090272A7A23018C45@SECTORBASE1 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> The problem appears to be that DataFill() is invoked on the tuple
> after toasting, and it forces the infomask to zero, losing any
> transaction status bits that may have been there. I think perhaps
> line 93 of heaptuple.c should be
>
> *infomask &= HEAP_XACT_MASK;
>
> not
>
> *infomask = 0;
>
> Comments anyone?
One should check all places from where DataFill called...
Btw, I've found that I unlocked buffer in heap_insert *after* WriteBuffer -
fixed.
2Jan - please note NO ELOG(ERROR)... comment in heap_update: can you move
toast
code below xlog one?
Vadim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | The Hermit Hacker | 2000-07-04 02:50:26 | Re: Re: [HACKERS] proposed improvements to PostgreSQL license |
| Previous Message | The Hermit Hacker | 2000-07-04 02:41:29 | Re: [HACKERS] proposed improvements to PostgreSQL license |