| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Extending amcheck to check toast size and compression |
| Date: | 2021-11-04 22:58:16 |
| Message-ID: | 8E42250D-586A-4A27-B317-8B062C3816A8@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 4, 2021, at 7:53 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> But, is it plausible to add test coverage for the new checks, or is
> that going to be too much of a pain?
It only takes about 20 additional lines in the regression test to check the code paths for raw sizes which are too large and too small, so I've done that in this next version. Testing corrupt compressed data in a deterministic, cross platform manner with a compact, easy to maintain regression test has eluded me and is not included here.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Adding-more-toast-pointer-checks-to-amcheck.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2021-11-04 23:23:34 | Re: Logical insert/update/delete WAL records for custom table AMs |
| Previous Message | Tomas Vondra | 2021-11-04 22:56:07 | Re: [sqlsmith] Failed assertion in brin_minmax_multi_distance_float4 on REL_14_STABLE |